search

jimweirich / rspec-given

Given/When/Then keywords for RSpec Specifications
https://github.com/jimweirich/rspec-given
MIT License
653 stars 61 forks source link

Natural assertions are disabled for JRuby 1.7.12 although they should work #44

Open xb opened 10 years ago

xb commented 10 years ago

Probably the offending code is 

OLD_JRUBY_IN_USE = JRUBY_IN_USE && (JRUBY_VERSION < '1.7.5')

in https://github.com/jimweirich/rspec-given/commit/d1d61d48461838844101257bb9c021958b059f29 which does a string comparison and no software version comparison.