Add support for rspec 3

searls commented 9 years ago

This PR is mirrored on the new repo here

There are currently 19 failing specs on master when running the latest versions of rspec.

[x] 9 specs fixed by @ronen's https://github.com/jimweirich/rspec-given/pull/43
[x] 2 specs fixed by reverting the part of the above change (does_not_match? was inadvertently wrapping Given::Failure objects)
[x] 8 specs fixed by passing expect a block when paired with the raise_error matcher

Before merging, it may make sense to attempt a travis build matrix that maintains rspec 2 support.

searls commented 9 years ago

ronen commented 9 years ago

@searls oh, just saw that you moved to the new repo. Makes sense.

I just posted a comment on old issue #31 and added two new issues #47 and #48 -- do you want me to repost them over on the new repo?

searls commented 9 years ago

Insofar as future issues and discussion should be on the new repo so we can actually maintain them: yes