search

jimy-byerley / pymadcad

Simple yet powerful CAD (Computer Aided Design) library, written with Python.
https://madcad.netlify.app/
GNU Lesser General Public License v3.0
215 stars 17 forks source link

boolean operations doesnt consistently simplify lines #106

Open jimy-byerley opened 6 months ago

jimy-byerley commented 6 months ago

Currently this is visible on the flat screw heads

image

the call to line_simplification in cut_mesh does not seem to return the same simplification on both sides

jimy-byerley commented 6 months ago

In this case, this is caused by flat triangles coming the from revolution generating the top circular surface. The ngons selections are stopping to flat triangles in the current boolean operations implementation.

This will be fixed by #107 first, but it could be good to make the the ngon selection robust to flat triangles anyway