jimy-byerley / pymadcad

Simple yet powerful CAD (Computer Aided Design) library, written with Python.
https://madcad.netlify.app/
GNU Lesser General Public License v3.0
208 stars 16 forks source link

Gears #5

Closed bourbonut closed 3 years ago

bourbonut commented 3 years ago

Hi jimy-byerley,

I worked on gear.py in the branch gears. The goal was to create an entire gear thanks to one function gear(...). I used gearprofile to generate a tooth profile for the gear and I added some functions:

I would like to give you some details for circle_pattern & rect_pattern / rounded_pattern. Here is how I configured circle_pattern. circle_pattern_schema

Here is how I configured rect_pattern / rounded_pattern. rect_pattern_schema Just note that I used the function bevel in rounded_pattern to transform straight angles in rounded angles but parameters stay the same.

If you have any questions, don't hesitate ! I hope that you will understand all and you will like my request.

Best regards. bourbonut

jimy-byerley commented 3 years ago

Hello bourbonut ! Finally that long and hard work is closed to the end ! I was quite impatient at looking into the final work. I will take a deep look into it in the next days ! (And for whaterver reason, github is showing even more modified lines that what it is in reality ... Surely some dark story of spaces laying at the end of some lines of one of the files ;) )

jimy-byerley commented 3 years ago

For some reasons it doesn't appear here is it should (I should have make some mistake in my commands). But I made fex slight changes, that I merged on the gears branch !

I think I will continue on the following