search

jimy-byerley / pymadcad

Simple yet powerful CAD (Computer Aided Design) library, written with Python.
https://madcad.netlify.app/
GNU Lesser General Public License v3.0
211 stars 17 forks source link

Upgrade to PyQt6, fix Mac compatibility (on my computer?) #80

Closed GenieTim closed 1 year ago

GenieTim commented 1 year ago

This possibly fixes #33, if I get some confirmation that other Apple computers prefer this update as well, as for me, this version works now. Could also be that I meanwhile installed some dependency that is required, by chance, and that fixed it, but would need some input from someone else to know for sure.

For now, this PR is a draft, as there is some restructuring required for PyQt6 that I have not yet realised.

jimy-byerley commented 1 year ago

So Qt6 is fixing this for (at least some) apple computers ? That's good !

Migrating from PyQt5 to PyQt6 is not a minor change ... it will require a load of changes in all the projects integrating madcad in their GUIs. I am thinking in particular to uimadcad and some professional projects I have, but same problem with other projects I don't know about, using the madcad rendering pipeline. I and @bourbonut have a project for reworking the rendering pipeline, which will make it compatible with both Qt5 and Qt6.

Do you think you could try to reproduce making madcad work on your apple computer with a minimal python packages installation (like in a venv) ? Once we are sure it is Qt6 and not any other package that fixed madcad, I propose we merge your PR in a branch dedicated to Qt6 in the wait for the rendering pipeline refactoring, so mac-os users would be able to install pymadcad from this branch.

GenieTim commented 1 year ago

As seen in #82, it is not actually the upgrade to Qt6 that fixes things for MacOS. I guess if you will implement the upgrade to Qt6 yourself, you can close this PR?

jimy-byerley commented 1 year ago

sounds reasonable :+1: