search

jimz011 / homekit-infused

Homekit Infused 5 2023
https://jimz011.github.io/homekit-infused/
Other
878 stars 137 forks source link

show_header field in views.yaml: Boolean has no effect #156

Closed toollu closed 2 years ago

toollu commented 2 years ago

In a config where the show_header flag is set to false, e.g.:

# views.yaml (example with custom subtitle)
  living_room:
    show_header: false
    subtitle: Overview
    icon: mdi:floor-lamp

the boolean has no effect, e.g. the header is still shown in the living_room view.

jimz011 commented 2 years ago

Did you restart after adding this? Secondly, the navigation bar itself doesn't count as the HKI header.

Could you perhaps share a screenshot of what you are seeing?

toollu commented 2 years ago

Yes I did restart.

I see this:

IMG_3816

Although through:

  my_view:
    title: All Lights
    show_header: false
    show_in_favorites: true
    show_in_navbar: true
    show_in_menu: true
    icon: mdi:lightbulb
    addons:
    #...

the top bar with title and the badges should be hidden unless I misunderstood something.

This is on HKI5 2022.3.0

jimz011 commented 2 years ago

Ah, that is why.

The feature was added in https://github.com/jimz011/homekit-infused/releases/tag/2022.4.0

toollu commented 2 years ago

Ah ok my bad, I was probably using the old version with the new docs. Will close in this case. Many thanks for the quick help and your great work!