search

jinSasaki / InAppPurchase

A Simple and Lightweight framework for In App Purchase (Store Kit 1)
MIT License
288 stars 30 forks source link

Fixed a crash that is caused by AppStore Promoting Payment #20

Closed jinSasaki closed 6 years ago

jinSasaki commented 6 years ago

Fixed #19

Only if purchase via AppStore Promoting, SKProduct#priceLocale has been not initialized. It occurs a BAD_ACCESS crash. This is a StoreKit bug. This pull request resolves the crash that is occurred when received the payment, but it occurs when accessed Product#priceLocale yet. So, I recommend not to use Product#priceLocale in AppStore Promoting Payment process.

codecov[bot] commented 6 years ago

Codecov Report

Merging #20 into master will increase coverage by 0.1%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #20     +/-   ##
=========================================
+ Coverage   97.04%   97.15%   +0.1%     
=========================================
  Files           5        5             
  Lines         237      246      +9     
=========================================
+ Hits          230      239      +9     
  Misses          7        7
Impacted Files Coverage Δ
Sources/Product.swift 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1ae7701...d529636. Read the comment docs.