search

jinSasaki / InAppPurchase

A Simple and Lightweight framework for In App Purchase (Store Kit 1)
MIT License
288 stars 30 forks source link

Make PaymentState.state and transaction public. #44

Closed yanyin1986 closed 4 years ago

yanyin1986 commented 4 years ago

Hi, with InAppPurchase v2.1.4. I did validate the transaction which returned by the callback of addTransactionObserver. After v2.3.0, I found I can't do that anymore.

image

It will be work after making state and transaction public. Thanks.

codecov[bot] commented 4 years ago

Codecov Report

Merging #44 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #44   +/-   ##
=======================================
  Coverage   95.25%   95.25%           
=======================================
  Files           6        6           
  Lines         253      253           
=======================================
  Hits          241      241           
  Misses         12       12
Impacted Files Coverage Δ
Sources/InAppPurchase.swift 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 119b5a9...64328ae. Read the comment docs.

calda commented 4 years ago

+1, cd4f179 broke this important functionality.

mdcdeveloper commented 4 years ago

+1, I have to send to server side the transactionIdentifier, that's the identifier in our app. Waiting to merge! Please! Anyway when I print it it print's out the id's so I don't see why this is not public. Thanks in advance!