sse logserver can not start because of "flask" and "flask_cors" are missing

jina-ai / cookiecutter-jina

Cookiecutter template for a Jina project

Apache License 2.0

10 stars 2 forks source link

sse logserver can not start because of "flask" and "flask_cors" are missing #20

Closed alexcg1 closed 4 years ago

alexcg1 commented 4 years ago

Problem python app.py index fails with error message (errors.log)

Info

I started this on a clean version of my-first-jina-app with nothing installed except from requirements.txt
Looks like jina[http] doesn't include a few important things

rutujasurve94 commented 4 years ago

Hey, there are extra requirements while using http it seems as per: https://github.com/jina-ai/jina/blob/075108deaaac58297370d1448405029fb172b7e1/extra-requirements.txt

should we include this as well?

alexcg1 commented 4 years ago

Yes, I think we should, since cookiecutter should create a full project out of the box (just the http ones obviously. no need for audio for example

hanxiao commented 4 years ago

flask and this requires user to install jina[devel], you can add a if-else branch in the cookiecutter.

hanxiao commented 4 years ago

I add this to readme

rutujasurve94 commented 4 years ago

I add this to readme

Sure, I had also added the extra-requirements to https://github.com/jina-ai/cookiecutter-jina/pull/19/files that include flask, etc.

rutujasurve94 commented 4 years ago

This has been fixed and both indexing and querying work fine. Requirements are upto-date as well