search

jina-ai / cookiecutter-jina

Cookiecutter template for a Jina project
Apache License 2.0
10 stars 2 forks source link

Run the tests of a base class on the derived classes as well. #39

Open florian-hoenicke opened 3 years ago

florian-hoenicke commented 3 years ago

In the base classes, we define abstracted methods. Some of the derived classes share the same test logic. This leads to redundant code. Since we decided to not test hub components from within the core, we have to live with the redundancy. However, we can auto generate tests when using the cookie cutter. Please implement the test generation for KVIndexers and VectorIndexers.

cristianmtr commented 3 years ago

Maybe reformat and clean up the description?

florian-hoenicke commented 3 years ago

Right, it was just a copy from the slack conversation. I summarized the findings and updated the description.

JoanFM commented 3 years ago

I think this can be time saver but can be quite missleading and let people think that these tests can be enough; when certain executors require specific edge cases.

I would put low priority to this.