search

jina-ai / cookiecutter-jina

Cookiecutter template for a Jina project
Apache License 2.0
10 stars 3 forks source link

Dockerfile labels #42

Open alexcg1 opened 3 years ago

alexcg1 commented 3 years ago

To be able to push to Jina Hub a Dockerfile needs a whole bunch of labels. See wiki search Dockerfile as an example.

We should put these into the Dockerfile generated by cookiecutter

JoanFM commented 3 years ago

The labels I believe are extracted from the manifest.yml so I think this is not needed

alexcg1 commented 3 years ago

When I ran jina push ... it definitely wanted them in the Dockerfile. It threw error. I added it in Dockerfile, then it worked.

My manifest.yml doesn't even contain type and kind, so jina push must be skipping it

My manifest.yml:

manifest_version: 1
name: jina-wikipedia-sentences-50k
description: 'Example Jina Flows for searching 50,000 sentences from Wikipedia'
author: Jina AI Dev-Team (dev-team@jina.ai)
url: https://jina.ai
vendor: Jina AI Limited
documentation: https://github.com/alexcg1/jina-wikipedia-sentences
version: 0.0.1
license: apache-2.0
keywords: [NLP, wikipedia, text, distilbert]
alexcg1 commented 3 years ago

It states 50k bc that was my original plan. I haven't touched it for ages