jina-ai / cookiecutter-jina

Cookiecutter template for a Jina project
Apache License 2.0
10 stars 2 forks source link

feat: use version matching clause #47

Closed ddelange closed 3 years ago

ddelange commented 3 years ago

Hi!

I looked at the CHANGELOG and couldn't quickly spot breaking changes until 1.0.7 versus 0.8.2 (are there any that need to be considered here, since the major version was bumped?). I've made the changes below assuming semantic versioning (dropping patch version here affects both dockerhub and pypi, see below), but as it's a major version bump, this PR might need some extra eyes to ensure the bump to v1 is fine.

Changes:

Side question: do you already have plans for some checks for this repo? Maybe something like:

Yongxuanzhang commented 3 years ago

@ddelange The elaboration in this PR is really good and well-organized. Which I learned a lot! Looking forward to your contributions! ❤️

alexcg1 commented 3 years ago

Hey @ddelange thanks so much for your PR! I would've loved to merge it - cookiecutter has been a thorn in my/our side for so long now. And you did a wonderful job explaining what you did and why.

We're looking at options right now for replacing cookiecutter with something more suitable and flexible. Would love your feedback on that once it goes live