search

jina-ai / dashboard

Interactive UI for analyzing Jina logs, designing Flows and viewing Hub images
https://dashboard.jina.ai
Apache License 2.0
118 stars 60 forks source link

Add integration tests for log view #138

Closed ravishankarste closed 3 years ago

BastinJafari commented 3 years ago

Thank you very much for your PR @ravishankarste We have changed the Design of flowView, so it doesn't contain a dropdown anymore and also use data-* attributes.

https://docs.cypress.io/guides/references/best-practices.html#Selecting-Elements

Feel invited to add additional tests to the existing ones!

Edit: Misread flow view for log view. My bad!

BastinJafari commented 3 years ago

Hey Ravi, thanks for the changes! I checked out your branch and the tests were failing (npm run cy:runor npm run cy:dev). You are referencing attributes that don't exist in the code like "dropDown-3-ViewSelectedOption"

ravishankarste commented 3 years ago

Hey Bastin

I expected that to happen because I made some changes in dev code but i didn't push.. I asked josh if I can push that as well... If it's ok i will push those changes as well.

On Mon, 15 Feb, 2021, 9:35 AM Bastin, notifications@github.com wrote:

Hey Ravi, thanks for the changes! I checked out your branch and the tests were failing (npm run cy:run or npm run cy:dev). You are referencing attributes that don't exist in the code like "dropDown-3-ViewSelectedOption"

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jina-ai/dashboard/pull/138#issuecomment-779092498, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALMUFZGQS6HPI2HUNCE2KVDS7DTGXANCNFSM4WXM3IYQ .

BastinJafari commented 3 years ago

That would be nice. Also checkout the newest version. I added a test for checking the correct logging output:

image

Maybe you could add to that and check if it is also correct for all the dropdown categories

ravishankarste commented 3 years ago

Thanks, I'll check it out.

On Tue, Feb 16, 2021 at 1:16 PM Bastin notifications@github.com wrote:

That would be nice. Also checkout the newest version. I added a test for checking the correct logging output:

[image: image] https://user-images.githubusercontent.com/25417797/108067712-79a61c00-7061-11eb-8dc3-04b38996202e.png

Maybe you could add to that and check if it is also correct for all the dropdown categories

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jina-ai/dashboard/pull/138#issuecomment-779829480, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALMUFZCXAPEWZT6A4EO3C5TS7JV3TANCNFSM4WXM3IYQ .

Roshanjossey commented 3 years ago

Closing this in favour of #277