jina-ai / dashboard

Interactive UI for analyzing Jina logs, designing Flows and viewing Hub images
https://dashboard.jina.ai
Apache License 2.0
118 stars 61 forks source link

feat: fetch arguments from jinad and api #163

Closed imsergiy closed 3 years ago

imsergiy commented 3 years ago
codecov[bot] commented 3 years ago

Codecov Report

Merging #163 (0664507) into master (c844b58) will increase coverage by 3.14%. The diff coverage is 73.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
+ Coverage   21.66%   24.81%   +3.14%     
==========================================
  Files         138      142       +4     
  Lines        2695     2801     +106     
  Branches      443      451       +8     
==========================================
+ Hits          584      695     +111     
+ Misses       2111     2106       -5     
Impacted Files Coverage Δ
src/components/FlowChart/Sidebar.tsx 0.00% <ø> (ø)
src/data/exampleFlows.ts 100.00% <ø> (ø)
src/layouts/IconSidebar.tsx 0.00% <0.00%> (ø)
src/modals/PodEdit.tsx 0.00% <0.00%> (ø)
src/redux/flows/flows.selectors.ts 0.00% <0.00%> (ø)
src/redux/logStream/logStream.constants.ts 100.00% <ø> (ø)
src/redux/logStream/logStream.types.ts 0.00% <ø> (ø)
src/views/FlowView.tsx 0.00% <0.00%> (ø)
src/services/jinad.ts 12.32% <46.66%> (+8.67%) :arrow_up:
src/services/hubApi.ts 85.71% <50.00%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c844b58...0664507. Read the comment docs.

BastinJafari commented 3 years ago

Nice PR! Have some minor suggestions