search

jina-ai / dashboard

Interactive UI for analyzing Jina logs, designing Flows and viewing Hub images
https://dashboard.jina.ai
Apache License 2.0
118 stars 61 forks source link

Refactor: Delete store and unused code #169

Closed BastinJafari closed 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #169 (3f82799) into master (0fc113f) will increase coverage by 7.63%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #169      +/-   ##
==========================================
+ Coverage   25.19%   32.83%   +7.63%     
==========================================
  Files         142      133       -9     
  Lines        2786     2138     -648     
  Branches      451      360      -91     
==========================================
  Hits          702      702              
+ Misses       2084     1436     -648
Impacted Files Coverage Δ
src/apps/Dashboard.tsx 0.00% <0.00%> (ø)
src/apps/Hub.tsx 0.00% <ø> (ø)
src/components/Layout/MainNavbar/MainNavbar.tsx 0.00% <ø> (ø)
src/layouts/HubLayout.tsx 0.00% <0.00%> (ø)
src/layouts/IconSidebar.tsx 0.00% <0.00%> (ø)
src/views/LogIn.tsx 0.00% <0.00%> (ø)
src/views/PackageView.tsx 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0fc113f...3f82799. Read the comment docs.

Roshanjossey commented 3 years ago

image

Percy caught something. @BastinJafari, could you check the elements in the footer? Not sure what it has to do with store though.

BastinJafari commented 3 years ago

I deleted a lot of components that I thought wouldn't get used anymore. So maybe that's why something visually has changed because it actually got used. Regarding this display bug, I can't reproduce it.