jina-ai / dashboard

Interactive UI for analyzing Jina logs, designing Flows and viewing Hub images
https://dashboard.jina.ai
Apache License 2.0
118 stars 61 forks source link

"Save" button at Flow Design page of Dashboard doesn't work #288

Closed franquil closed 3 years ago

franquil commented 3 years ago

Describe the bug

There's no response when clicking the "Save" button at the Flow Design page of the dashboard.

Have you solved it? If so, let us know how!

This PR #289 could fix the issue.


It looks like the target element .chart-container for capturing image doesn't exist. A easy fix could be replacing the element with .reactflow-wrapper which is using currently.

Environment

Process to reproduce the bug:

docker run -p 8000:8000 -p 5555:5555 jinaai/jina:master-daemon
cd dashboard && npm run dev
# visit 'http://localhost:3000/#/flow' and click the 'Save' button at command bar

Screenshots and logs

There's no visible response or console logs output.

franquil commented 3 years ago

Since the corresponding PR was merged, the issue should be closed.