Update details page to correctly pull README

jina-ai / dashboard

Interactive UI for analyzing Jina logs, designing Flows and viewing Hub images

https://dashboard.jina.ai

Apache License 2.0

118 stars 61 forks source link

Update details page to correctly pull README #297

Closed lusloher closed 3 years ago

lusloher commented 3 years ago

Acceptance criteria:

the README for all the Hub Images is correctly populated with the README of that Image
all 7 types of executors are handled
[x] crafters
[x] rankers
[x] indexers
[x] segmenters
[x] encoders
[x] classifiers
[x] evaluators

lusloher commented 3 years ago

Link to subfeature: https://jinaai.productboard.com/feature-board/planning/features/7471108

aga11313 commented 3 years ago

Lets split this up:

[ ] crafters - @BastinJafari
[ ] rankers - @imsergiy
[ ] segmenters - @JoanFM
[ ] classifiers - @Roshanjossey
[ ] evaluators - @niuzs-alan

An example of the kind of change we need: https://github.com/jina-ai/jina-hub/pull/7578

REMEMBER TO BUMP THE VERSION NUMBER when changing the url

aga11313 commented 3 years ago

@JoanFM if you can take the Segmenters that would be great :)

JoanFM commented 3 years ago

I did a quick look and updated I think everyone missing in 2 PRs

JoanFM commented 3 years ago

jina-ai/jina-hub#7792 jina-ai/jina-hub#7791

JoanFM commented 3 years ago

Is the only problem handled here the link in the url?

aga11313 commented 3 years ago

Yeah I think so @Roshanjossey @deepankarm , what was the rationale behind doing this in multiple PRs?

JoanFM commented 3 years ago

The tests are better handled in multiple PRs, but we can do it once at batch, and next dependabot update will expose the right value.

If we do it in these 2 PRs, not all the images will be built, but we can have a batch and will quickly be updated, and will imply less engineering effort