jina-ai / dashboard

Interactive UI for analyzing Jina logs, designing Flows and viewing Hub images
https://dashboard.jina.ai
Apache License 2.0
118 stars 61 forks source link

Fix/300 filter interface cleanup #315

Closed Roshanjossey closed 3 years ago

Roshanjossey commented 3 years ago

PR checklist

Docs

Tests

Typing

Styling

Roshanjossey commented 3 years ago

Address https://github.com/jina-ai/dashboard/issues/300

codecov[bot] commented 3 years ago

Codecov Report

Merging #315 (d6e5eb0) into master (7e5ec1b) will increase coverage by 0.60%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #315      +/-   ##
==========================================
+ Coverage   65.57%   66.17%   +0.60%     
==========================================
  Files          62       62              
  Lines        1409     1434      +25     
  Branches      217      218       +1     
==========================================
+ Hits          924      949      +25     
  Misses        485      485              
Impacted Files Coverage Δ
src/services/hubApi.ts 94.11% <ø> (ø)
src/redux/hub/hub.actions.ts 90.00% <100.00%> (+4.28%) :arrow_up:
src/redux/hub/hub.constants.ts 100.00% <100.00%> (ø)
src/redux/hub/hub.reducer.ts 100.00% <100.00%> (ø)
src/redux/hub/hub.selectors.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7de3450...d6e5eb0. Read the comment docs.

BastinJafari commented 3 years ago

Nice PR! Added some comments about naming, Material and data types