Closed hanxiao closed 3 years ago
@hanxiao some input: You have a lot of changed lines because your editor does not use the project config for code formatting. That makes it difficult to properly find out the other of some line of code without extra work and will result in another PR with many changed lines, when the next person, that uses the project config for code formatting opens a PR.
You should fix that in your editor settings. It would be awesome if the general culture would lead to somebody telling you this despite you being the CEO. But that's something that is actually quite hard to achieve.
I didn't check how the pipeline and the CI works but in general, it would be best to set it up in the following way: CI runs the code formatted over-committed code and fails if there are any changes. That ensures, that there cannot be some formatting hiccup, not reviewed by a dev, that actually changes the functionality of the code. On top of that, I'd recommend a commit hook, that formats all code that's added to a commit.
(:
I know it's already merged but since it feels like nobody says something because you're the boss, I felt like it couldn't hurt to chime in (:
All the best and congratulations on 2.0 from my side. Take care, David
PR checklist
Please tick all of the below (if a certain item is not required for this PR please tick the box anyway)
Docs
Tests
Typing
Styling