fix: update usage of SimpleIndexer to new API

jina-ai / examples

Jina examples and demos to help you get started

https://docs.jina.ai

Apache License 2.0

453 stars 140 forks source link

fix: update usage of SimpleIndexer to new API #726

Open cristianmtr opened 3 years ago

cristianmtr commented 3 years ago

The SimpleIndexer is used in a lot of examples.

However, it is using the old API.

The task is to check all the examples that use SimpleIndexer still work and fix the version to a specific version, like /v0.3.

SimpleIndexer hub image: https://hub.jina.ai/executor/zb38xlt4

m4rtinkoenig commented 2 years ago

Hi @cristianmtr,

I tested the wikipedia-sentence example.

It works as expected and the test passed.

Screenshot 2021-09-27 at 01 32 00

Affected example

[x] wikipedia-sentences
[ ] multires-lyrics-search
[ ] cross-modal-search
[ ] audio-to-audio-search

cristianmtr commented 2 years ago

Hey @m4rtinkoenig

Thanks for helping. Are you going to take over this ticket completely?

It means checking these examples, fixing any issues, and then fixing the tag of the SimpleIndexer to specific tag, like v0.3

m4rtinkoenig commented 2 years ago

Yes, but I am currently working on another issue on jina core. I just wanted to post my progress and see if CI tests pass :D If anyone wants to take over feel free and leave a short note