search

jina-ai / executor-3d-encoder

An executor that wraps 3D mesh models and encodes 3D content documents to d-dimension vector.
17 stars 5 forks source link

In `farthest_point_sample` function, the first centroid sampled is not random. #14

Closed elenacliu closed 1 year ago

elenacliu commented 2 years ago

I'm reading your codes.

https://github.com/jina-ai/executor-3d-encoder/blob/main/executor/models/modules.py#L75

The randint line is commented, but in the original implementation and the algorithm itself, it should be random? Maybe we can provide a fixed seed if we want to get the same result?

numb3r3 commented 1 year ago

Based on the codes, we can see farthest is a temporal variable to record the maximal position latitude. In this case, I think zero initialization should be better than randomness.