jina-ai / executor-normalizer

Jina executor package normalizer
5 stars 0 forks source link

load secret/environ using script and hide it from user #58

Closed nomagick closed 1 year ago

nomagick commented 2 years ago

Currently, the secret/environ is loaded using bare statements:

RUN --mount=type=secret,id=DOMAIN --mount=type=secret,id=REPO export DOMAIN="$(cat /run/secrets/DOMAIN)" export REPO="$(cat /run/secrets/REPO)"  &&   pip install --no-cache-dir -r requirements.txt

This is very ugly. Especially when there are multiple target environs, this statement is going on forever. This hurts the user experience because they will receive the log about the statement which has been changed from their original input.

Goals:

nomagick commented 1 year ago

Fixed by https://github.com/jina-ai/hubble/pull/706

nomagick commented 1 year ago

The custom dockerfile is done by https://github.com/jina-ai/buildkit/pull/1

Rebased to the latest dockerfile release 1.4.3 branch: https://github.com/jina-ai/buildkit/tree/dockerfile/1.4.3-magic-shell

Published to https://hub.docker.com/r/jinahub/dockerfile