search

jina-ai / executors

internal-only
Apache License 2.0
31 stars 12 forks source link

feat: add key length to simple indexer #130

Closed JoanFM closed 3 years ago

numb3r3 commented 3 years ago

@JoanFM this PR looks good to me. And I have a suggestion about the DAM implementation, is it reasonable to throw a warning if the length of doc.id is larger than the key_length?

JoanFM commented 3 years ago

@JoanFM this PR looks good to me. And I have a suggestion about the DAM implementation, is it reasonable to throw a warning if the length of doc.id is larger than the key_length?

It would make sense, would u make a PR?