refactor: rankers - Githubissues

jina-ai / executors

internal-only

Apache License 2.0

31 stars 12 forks source link

Closed tadejsv closed 2 years ago

tadejsv commented 2 years ago

[x] DPRReaderRanker
[x] SimpleRanker - I have decided to add this one, as it is actually used in our examples, and seems quite important. I have slightly generalized it, because the current structure of looking for matches in the chunks seemed very particular to our lyrics example - I see no reason why going to matches directly shouldn't be a part of this executor.

tadejsv commented 2 years ago

@nan-wang @bwanglzu please re-check

cristianmtr commented 2 years ago

If this breaks the API, push the old version manually first, to have it. Like how we did for SimpleIndexer

tadejsv commented 2 years ago

@cristianmtr The changes are backwards compatible

tadejsv commented 2 years ago

@nan-wang ready to merge