Closed CatStark closed 3 years ago
Just to understand this correctly: Do we want one executor that can read every data type or should we have separate executors for separate data types? @CatStark @nan-wang
Just to understand this correctly: Do we want one executor that can read every data type or should we have separate executors for separate data types? @CatStark @nan-wang
@jacobowitz sorry, I read the message wrongly. For loading each type, We want to have one executor.
The main point here is, that it is not just a data loader from somewhere but at the same time a decoder. E.g. the Mp3Decoder
should:
convert_uri_to_buffer
(and load data from disk/anywhere in the internet)Decision from alignment meeting: We should have one Decoder/Loader per media type for now. One AudioLoader
and one VideoLoader
.
Just to understand this correctly: Do we want one executor that can read every data type or should we have separate executors for separate data types? @CatStark @nan-wang
@jacobowitz sorry, I read the message wrongly. For loading each type, We want to have one executor.
Alright, I understand :) Btw, I am @jakob1111996, not @jacobowitz (This would be Tobias)
Decision from alignment meeting: We should have one Decoder/Loader per media type for now. One
AudioLoader
and oneVideoLoader
.
Hi @jakob1111996, in yesterday's meeting we decided to have one executor per mime type. So, overall three executors - audio, video, and pptx. I will be working on this ticket too and am picking up video executors if you haven't started with video already. Just wanted to let you know so that we both don't end up doing the same work. :)
Nice @makram93 , I have started working on Audio, so we should be fine :)
@nan-wang, after discussion with @florian-hoenicke, we decided to skip the subtitle encoder for now as we don't see any use case currently.
For the audio reader, which data types should be supported? Right now, I am supporting MP3 and WAV. Any other types you think are necessary? AIFF, WEBM, FLAC, AAC, WMA, MP4, M4A? @nan-wang @makram93 @maximilianwerk
For the audio reader, which data types should be supported? Right now, I am supporting MP3 and WAV. Any other types you think are necessary? I suggest not supporting other types at the moment. Let's see what are requested by the community re after launching the hub.
after discussion with @florian-hoenicke, we decided to skip the subtitle encoder for now as we don't see any use case currently We are actually using this in one of the EAPs although this part is currently implemented by the user.
We are actually using this in one of the EAPs although this part is currently implemented by the user.
@nan-wang okay, I see. What video source files should be supported for subtitles?
okay, I see. What video source files should be supported for subtitles Let's focus on
.mp4
and save the outputs at.srt
usingffmpeg
.
Mp3Loader
executor-audio-mp3loader
WavLoader
executor-audio-wavloader
VideoFrameLoader
VideoAudioLoader
VideoSubtitleLoader
executor-subtitle-frameloader
PptxLoader
Reference