search

jina-ai / executors

internal-only
Apache License 2.0
31 stars 12 forks source link

DocCache rewrite #254

Closed cristianmtr closed 2 years ago

cristianmtr commented 2 years ago

We have removed content_hash field from Document.

The logic needs to be reimplemented in the DocCache to keep it working with latest version of Jina.

gauthamsuresh09 commented 2 years ago

Hi @cristianmtr, I was looking at this issue. The content_hash still exists in Document, not as a field but instead as a property. So, I'm not sure about the change you are proposing, because the code should work same as before.

cristianmtr commented 2 years ago

Yes you're right. Ran a test PR and all good. https://github.com/jina-ai/executors/pull/258