feat: delete pdf segmenter

jina-ai / executors

internal-only

Apache License 2.0

31 stars 12 forks source link

feat: delete pdf segmenter #325

Closed cristianmtr closed 2 years ago

cristianmtr commented 2 years ago

Goals:

upgrade pdf segmenter to 3.0
...
[ ] Bumped version (in README of Executor)

PR feedback: @jina-ai/workstream-hub

samsja commented 2 years ago

I think that you need to delete the

if not docs:
 ...

and the Optional[DocumentArra] from the functions signatures

(https://github.com/jina-ai/executors/blob/feat-upgrade-pdfsegmenter-3.0/jinahub/segmenters/PDFSegmenter/pdf_segmenter.py#L29)

cristianmtr commented 2 years ago

I think that you need to delete the
if not docs:
...
and the Optional[DocumentArra] from the functions signatures

(https://github.com/jina-ai/executors/blob/feat-upgrade-pdfsegmenter-3.0/jinahub/segmenters/PDFSegmenter/pdf_segmenter.py#L29)

Done

cristianmtr commented 2 years ago

Deleted from this repo. Moved to https://github.com/jina-ai/executor-pdfsegmenter/pull/1