search

jina-ai / executors

internal-only
Apache License 2.0
31 stars 12 forks source link

fix: min ranker becomes simple ranker #82

Closed jakobkruse1 closed 3 years ago

jakobkruse1 commented 3 years ago

The min ranker was not really a min ranker previously. We did sort the elements of the array descendingly, this means the maximum score is in the first place. This PR fixes this bug and repairs the Minranker to rank by minimum score (minimum distance).

Yongxuanzhang commented 3 years ago

Thanks for pointing it out. 😄

jakobkruse1 commented 3 years ago

Thanks for pointing it out. smile

The name of this executor is minranker - if we also allow mean and max ranking, we should probably rename it right?

nan-wang commented 3 years ago

if we also allow mean and max ranking, we should probably rename it right?

Yes, maybe SimpleRanker?