search

jina-ai / jina-hub

An open-registry for hosting Jina executors via container images
Apache License 2.0
105 stars 48 forks source link

Remove `array2pb` and `pb2array` function from hub #578

Closed maximilianwerk closed 3 years ago

maximilianwerk commented 4 years ago

The two above mentioned functions were removed from jina due to a refactoring. They are not needed anymore, but in some parts of the hub still existent. That should be refactored.

The PR in jina in which the refactoring happened is:

https://github.com/jina-ai/jina/commit/008638d3e61c20c585b376ea003be712123a6eb2#diff-78bac2537fa2f301f32229a6b3db4bc61686bde54b51ee15c94bfcbb77271feb

JoanFM commented 4 years ago

are they present in tests? or in executors themselves? If in executors it is quite a design flaw I think

maximilianwerk commented 4 years ago

are they present in tests? or in executors themselves? If in executors it is quite a design flaw I think

only in tests.

JoanFM commented 3 years ago

Can't find these usage anymore anywhere in the hub