Update uvicorn version - Githubissues

jina-ai / jina

☁️ Build multimodal AI applications with cloud-native stack

https://docs.jina.ai

Apache License 2.0

20.87k stars 2.22k forks source link

Update uvicorn version #5999

Closed JoanFM closed 2 months ago

JoanFM commented 1 year ago

Release of uvicorn 0.23.2 is making our tests hang because of the way how we handle websocket Gateway.

For now, we have fixed the uvicorn version, but it would be ideal to find the reason and unpin the version to profit from new benefits from it

jina-bot commented 10 months ago

@jina-ai/product This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 14 days

JoanFM commented 9 months ago

@MimicTester1307 please assign yourself here

MimicTester1307 commented 9 months ago

@MimicTester1307 please assign yourself here

@JoanFM I can't seem to assign myself, as I am not a collaborator. Please assign the issue to me.

JoanFM commented 9 months ago

I do not find how, but do not worry, u can start working on it

MimicTester1307 commented 9 months ago

Alright, thanks

MimicTester1307 commented 8 months ago

Hi @JoanFM. In trying to reproduce the error, I found a couple of things and have some questions. Maybe it's due to my local setup, so I want to clarify:

the build is tested against Python versions 3.7 & 3.8, right? Are there plans to upgrade to a later version?
the current version of Jina depends on docarray <=0.21.0, but it seems that the build is configured to download the latest version of docarray. This caused some tests to fail. Please find attached a sample image below:

I will downgrade to the recommended version of docarray, but I just wanted to point this out.

JoanFM commented 8 months ago

for 1. We could chnage in the future, but is not related to this issur.

for 2. Jina is compatible with every docarray version, but we had so many tests with docarray 0.21.0 that we kept most of the tests unchanged and we install that version in our ci/cd

MimicTester1307 commented 8 months ago

Yes, the python version isn't related. I was just curious.

I see. Somehow it was the latest version of docarray that was installed in my environment. Maybe along the line the tests can be updated to use the latest version of docarray. In the meantime, I'll downgrade my version and just work on this issue. Thanks

JoanFM commented 8 months ago

it is a really big effort to change to the docarray version, and it would not add so much value.

jina-bot commented 5 months ago

@jina-ai/product This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 14 days

jina-bot commented 2 months ago

@jina-ai/product This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 14 days