search

jina-ai / jina

☁️ Build multimodal AI applications with cloud-native stack
https://docs.jina.ai
Apache License 2.0
20.63k stars 2.21k forks source link

refactor: refactor env var reading in docs/conf.py #6043

Closed ai-naymul closed 10 months ago

ai-naymul commented 10 months ago

Centralized the environment variable in the conf.py, refactor the code in constants.py

codecov[bot] commented 10 months ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.75% :warning:

Comparison is base (7529214) 75.21% compared to head (74d86f3) 74.47%. Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #6043 +/- ## ========================================== - Coverage 75.21% 74.47% -0.75% ========================================== Files 142 144 +2 Lines 13744 13789 +45 ========================================== - Hits 10338 10269 -69 - Misses 3406 3520 +114 ``` | [Flag](https://app.codecov.io/gh/jina-ai/jina/pull/6043/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jina-ai) | Coverage Δ | | |---|---|---| | [jina](https://app.codecov.io/gh/jina-ai/jina/pull/6043/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jina-ai) | `74.47% <100.00%> (-0.75%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jina-ai#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/jina-ai/jina/pull/6043?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jina-ai) | Coverage Δ | | |---|---|---| | [jina/\_\_init\_\_.py](https://app.codecov.io/gh/jina-ai/jina/pull/6043?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jina-ai#diff-amluYS9fX2luaXRfXy5weQ==) | `56.00% <100.00%> (ø)` | | | [jina/constants.py](https://app.codecov.io/gh/jina-ai/jina/pull/6043?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jina-ai#diff-amluYS9jb25zdGFudHMucHk=) | `96.55% <100.00%> (-0.12%)` | :arrow_down: | ... and [53 files with indirect coverage changes](https://app.codecov.io/gh/jina-ai/jina/pull/6043/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jina-ai)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JoanFM commented 10 months ago

Thanks for the contribution!!