search

jina-ai / jina

☁️ Build multimodal AI applications with cloud-native stack
https://docs.jina.ai
Apache License 2.0
20.63k stars 2.21k forks source link

fix(consensus): free allocated CStrings #6054

Closed thechampagne closed 9 months ago

thechampagne commented 10 months ago

Goals:

codecov[bot] commented 10 months ago

Codecov Report

Patch coverage has no change and project coverage change: +0.03% :tada:

Comparison is base (3652cfd) 77.01% compared to head (40585fc) 77.05%. Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #6054 +/- ## ========================================== + Coverage 77.01% 77.05% +0.03% ========================================== Files 145 145 Lines 13879 13879 ========================================== + Hits 10689 10694 +5 + Misses 3190 3185 -5 ``` | [Flag](https://app.codecov.io/gh/jina-ai/jina/pull/6054/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jina-ai) | Coverage Δ | | |---|---|---| | [jina](https://app.codecov.io/gh/jina-ai/jina/pull/6054/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jina-ai) | `77.05% <0.00%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jina-ai#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/jina-ai/jina/pull/6054?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jina-ai) | Coverage Δ | | |---|---|---| | [...ina/serve/runtimes/gateway/graph/topology\_graph.py](https://app.codecov.io/gh/jina-ai/jina/pull/6054?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jina-ai#diff-amluYS9zZXJ2ZS9ydW50aW1lcy9nYXRld2F5L2dyYXBoL3RvcG9sb2d5X2dyYXBoLnB5) | `71.81% <0.00%> (+0.81%)` | :arrow_up: | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/jina-ai/jina/pull/6054/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jina-ai)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JoanFM commented 10 months ago

Thank you for the contribution, may I ask how did you spot this error? there may be others in the code.

Thanks

JoanFM commented 9 months ago

Would this also require change?

LogLevel                 = C.CString(raftDefaultConfig.LogLevel)
thechampagne commented 9 months ago

Would this also require change?

Yes it should be freed, totally forgot it.

thechampagne commented 9 months ago

Thank you for the contribution, may I ask how did you spot this error? there may be others in the code.

Thanks

Reading the code :skull: not all of it for sure.