Closed NarekA closed 8 months ago
Attention: 4 lines
in your changes are missing coverage. Please review.
Comparison is base (
f2085a9
) 75.98% compared to head (b462c90
) 74.91%. Report is 3 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Can you open in parallel a PR with your fix to the GET parameter, before we actually revert this?
Can you tell me how you reproduce the issue with a Gateway? I may be able to have it working?
@JoanFM I was able to do this without adding a post endpoint in the following PR. That PR just uses the existing get endpoint but adds an optional body param.
@JoanFM do you prefer to use the current endpoints with the gateway fixed or this?
I think the idea of keeping only the GET
endpoint is good.
Reverts jina-ai/jina#6093
@JoanFM, This PR had an issue, the change I made to the streaming delay test was a patch. It looks like streaming does not work when I use post with a gateway, however, I have been able to update the endpoint so
get
works with either query params or a json body. Let's revert this and I will push my new branch.