Closed NarekA closed 7 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
1c2a7c2
) 73.86% compared to head (bc91179
) 75.18%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hey @NarekA,
Thanks for the contribution, can you check the failed tests and add a test showing what u are intending to fix?
@JoanFM I think the issue came about because I was using request.content_type
instead of response.content_type
. I think the latest commit should fix it.
Most of the errors on tests will be fixed by #6124
@JoanFM I'm finding these tests to be prohibitively difficult to debug. Any idea what is going wrong? I need a better way of replicating them locally.
Thanks for this great contribution!
The current load balancer assumes all
GET
requests are streaming and allPOST
requests are not. This may not be true for user-added fast-api endpoints and in the past we have talked about usingPOST
for streaming. (One of the benefits of this is the Swagger UI better documents the payload forPOST
endpoints).It makes more sense to use the response content-type to determine when to stream.
Goals: