jing-xiang / pe

0 stars 0 forks source link

Unable to 'cancel' to exit recommendation page #12

Open jing-xiang opened 5 months ago

jing-xiang commented 5 months ago

Expected result: I should be able to leave the recommendation page after typing 'cancel' as prompted by the program Actual: I am stuck in the loop even typing cancel multiple times

image.png

soc-pe-bot commented 5 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Can not use bye command when using the recommendation feature

Steps to reproduce: First enter recommend, then enter bye. Expected: Exit the program Actual: Show the message "Type 'cancel' if you would like to exit the recommendation page"

image.png


[original: nus-cs2113-AY2324S2/pe-interim#1953] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Currently, the bye command implementation only works outside of the recommendation phase. It might be useful to implement in the future for user convenience, but the program currently works well as intended.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: This is a complete different issue from the 'bye' command. I disagree because this is definitely not a duplicate issue. Sure, the 'bye' command not working in the recommendation feature may be intended, but what I am talking about in my bug report is the 'cancel' command, not the general 'bye' command. The 'cancel' command is quite clearly shown in the UI that it is an available option to exit the recommendation page if I choose to do so. Not only does it not work, but it causes a program breaking scenario where I am stuck in an infinite loop of this sequence unless I forcefully make my choice of continuing with the rest of the recommendation sequence. I really do not believe this is a duplicate issue. Feel free to reproduce this bug!


## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:** This bug cannot be not in scope, because not only is it completely in scope, it is also quite realistically shown in the UI print statement that typing 'cancel' is a feature that allows me to get out of this sequence. This choice of notinscope is clearly rejected and disagreed. ![image.png](https://raw.githubusercontent.com/jing-xiang/pe/main/files/171f4161-a839-4021-81eb-5641f8fec0ff.png)
## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [x] I disagree **Reason for disagreement:** This is a functionality bug as per the course website ![image.png](https://raw.githubusercontent.com/jing-xiang/pe/main/files/433acdfc-072f-495b-8759-df0adb04e528.png) Legitimate user input is not handled: 'cancel' command
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** Please see the video attached:
video:https://raw.githubusercontent.com/jing-xiang/pe/main/files/8075fa70-345a-44d6-a269-715e7dfd244a.mp4
As shown in the video, this issue is specific to the sequence of choosing the size (other sequences are fine) whereby I am repeatedly typing 'cancel' into the terminal but to no avail. ![image.png](https://raw.githubusercontent.com/jing-xiang/pe/main/files/b8ee86a0-b113-47b7-8946-2bb0f5745e05.png) This should be a severity of at least Medium as not only is it shown in the print statement that I am able to type 'cancel' to exit the recommend sequence, I am also stuck in an infinite loop whereby cancelling does not work and now I am unable to continue with the application nor exit the program. This bug is program breaking as if i want to cancel, I am forever stuck in this part and am unable to continue using the product unless I kill the program. This bug can be circumvented by better written JUnit tests. Considering the above, this bug could be within high severity territory as it is potentially program breaking because I am forced to choose a size instead of cancelling, making me unable to continue using the product. Hence, I disagree with the severity being lowered as the bug essentially prevents further usage.