search

jing-xiang / pe

0 stars 0 forks source link

Table formatting is unreadable #8

Open jing-xiang opened 6 months ago

jing-xiang commented 6 months ago

Steps to reproduce: when i have a flower with more than 1 color in a bouquet and try to remove it, the table that shows afterwards has poor formatting, even after changing to full screen. see below:

image.png

The MAIN_FLOWER keyword here is confusing and I'm unsure what it does. Moreover, not sure how the rows

nus-pe-bot commented 6 months ago

Team's Response

We have noted your concern and had taken the steps you have provided to reproduce this bug. However, under full screen mode, the table looks perfectly fine on our side (see below).

image.png

Secondly, under a non-full screen mode, users are advised to expand their terminal screen to fit the entirety of the line. Table or not table, the line will always break and the formatting will appear messy if the terminal is not expanded to an appropriate size.

We have attached a screen recording below to demonstrate 2 points. Firstly, we would like to show that expanding the tab to an appropriate size will result in the correct formatting of the table and secondly, that reducing the size of the tab will result in a messy format for not only the table, but for other texts as well, which is something that is bound to happen if users have reduced the tab size too small.


video:https://raw.githubusercontent.com/nus-cs2113-AY2324S2/pe/master/files/ae94bb6a-e5c7-4d7b-8a4c-9ea45d44fa10.mp4

Furthermore, the issue of "The MAIN_FLOWER keyword here is confusing and I'm unsure what it does. Moreover, not sure how the rows" is a separate issue and does not align with the title of this bug report. However, to answer the question, users may input flowers to see a list of different flowers, and type info <flowerName> to further see if the flower is a MAIN_FLOWER or FILLER_FLOWER. Type info Rose and info Freesia for comparison.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I disagree that this bug be rejected. As you can see from my screenshot, there is plenty of space on the right side of the terminal, hence there is a ascii table formatting issue. The use of MAIN_FLOWER and FILLER_FLOWER is also a cosmetic issue as it stands out from the other table elements.

I accept that the issue severity be lowered to very low as it is a cosmetic issue.

## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]