MacGyverr commented 8 months ago

Fixed missing flags and fixes for 20 and 21. Added new Kodi 21 requirement changes where noted. Disregard both "alt-flag" commits, one is a mistake the other undoes it.

MacGyverr commented 8 months ago

Disregard both "alt-flag" commits, one is a mistake the other undoes it. I barely can use Github.

jingai commented 8 months ago

Very much appreciated, as usual. I will merge when I get the chance.

MacGyverr commented 8 months ago

No problem, I do still use it after all. I just wish some artistic type could come up with a Metropolis styled tri-paned popup, it's needed in a few places and I keep kludging something together, but those are all ugly. I have zero art talent and Dall-e and ChatGPT can't seem to do subtle, as you can see by this example I tried to coax out of it.

But you can get a decent set of design elements out of it if you try hard enough, still over the top though.

We still need to refactor the whole thing at some point to use this style of element usage:

<include name="DefaultDialogButton">
    <param name="width">300</param>
    <param name="height">100</param>
    <param name="wrapmultiline">false</param>
    <param name="font">font25_title</param>
    <param name="onclick"></param>
    <param name="visible">true</param>
    <param name="enable">true</param>
    <definition>
        <control type="button" id="$PARAM[id]">
            <width>$PARAM[width]</width>
            <height>$PARAM[height]</height>
            <label>$PARAM[label]</label>
            <font>$PARAM[font]</font>
            <textoffsetx>20</textoffsetx>
            <onclick>$PARAM[onclick]</onclick>
            <wrapmultiline>$PARAM[wrapmultiline]</wrapmultiline>
            <align>center</align>
            <texturefocus border="40" colordiffuse="button_focus">buttons/dialogbutton-fo.png</texturefocus>
            <texturenofocus border="40">buttons/dialogbutton-nofo.png</texturenofocus>
            <visible>$PARAM[visible]</visible>
            <enable>$PARAM[enable]</enable>
        </control>
    </definition>
</include>

And then call the one include everywhere like this:

            <include content="DefaultDialogButton">
                <param name="width" value="350" />
                <param name="id" value="18" />
                <param name="label" value="$LOCALIZE[186]" />
            </include>

It can be done with almost all elements at this point and reduces the number of lines everywhere, makes it look more uniform as well as making it easy to make changes everywhere from one place. It's just a BUNCH of work and I might not live longer enough to finish it in my lifetime. :)

I'll look into it if I can find the time.

jingai commented 8 months ago

Aye, the biggest benefit to the skin at this point, IMHO, would be contributions from a real artist. That I am not. I took over the skin from Amra many years ago simply because I thought it was the best-looking and most sensibly-designed skin, and I wanted it to stick around.

There's loads to do in terms of refactoring and optimization, but at this point things generally work right, even if the code is a mess. If an artist approached me, it would likely motivate me to think more about it again. Until then though, I'm not unhappy with it (and neither is any member of my family), so I'm fine just keeping it up-to-date so it is available, which is completely thanks to you for the past few years, btw ;)

TBH, the download counts for the skin have never been insignificant relative to the others available -- with the exception of course of the Aeon variants -- so I'm a bit surprised no one has yet volunteered on the artwork front.

jingai commented 3 months ago

I will get to this once kodi 21 makes its way into Debian.

MacGyverr commented 2 months ago

I added a few more bug fixes a week or two ago at the request of some users, I didn't create a push for them though. I barely can get it synced with my local version and often have to rebase my stuff. I don't really know how to use github and struggle each time I have to use it. I also made a WIP release for 21 because people were having trouble installing the older version of it under 21. One day I hope to be able to point one of the AIs at the code and have it fix it for us. :)