search

jingai / skin.metropolis

Metropolis skin for Kodi
Other
9 stars 6 forks source link

Add DialogGameControllers #61

Closed jingai closed 3 years ago

jingai commented 8 years ago

See http://forum.kodi.tv/showthread.php?tid=250862&pid=2279680#pid2279680

jingai commented 8 years ago

https://github.com/xbmc/xbmc/commit/7564cc2ff889f4e86fa27e128a667f137a204a6e

jingai commented 8 years ago

How about copying the Skin Shortcuts dialog layout? Put the OK, Reset, and Get More buttons at the bottom and keep the controller list on the left. It would provide for more space for the button configuration, so you wouldn't be forced to overlap the top area.

MacGyverr commented 8 years ago

I thought of that, but that view didn't seem very in line with Metropolis either. I'll see what I can do about converting it.

jingai commented 8 years ago

Well, yeah, it's not quite the same as the other dialogs, but we need an exception for dialogs that present so much information at once. I personally think the Skin Shortcuts skin fits that bill and would be fine to carry over to other dialogs.

I'm open to other ideas as well, but I do think there should be consistency; i.e., if you do something different with the game controller dialog, we should probably make the same changes to the skin shortcuts dialog.

MacGyverr commented 6 years ago

new one looks like this https://user-images.githubusercontent.com/6500800/34463908-2062ce8e-ee20-11e7-8c1f-4377721265b9.png