search

jingedawang / StockPredictor

Predict the stock price with AI models.
http://stockprediction.org/
MIT License
21 stars 6 forks source link

Docker the environment to provide a one-step setup solution #22

Open jingedawang opened 2 years ago

vincilee2 commented 1 year ago

What should be put into Docker image? Two options: First, we just put Python, conda, playwright, etc without code. Second, we put both code and dependencies together, and build everything ahead. For the first option, we can provide script for users to fetch latest code and build everything inside Docker. For the second option, we need to publish a new version of docker image when code changed.

jingedawang commented 1 year ago

I guess, if this is a mature app, we should use the second option. We could use automatic GitHub action to publish the docker image in every release.

But now, I'm not ready to do it. Actually, it's not necessary to provide a docker. The code itself is not ready to release a stable version.

jingedawang commented 1 year ago

Are you interested in contributing?

vincilee2 commented 1 year ago

Yes, please assign it me

jingedawang commented 1 year ago

Did you check other issues that are marked with bug or enhancement? Or do you still want to take this issue? I can add you as collaborator and then you might be able to pick the issue directly.

vincilee2 commented 1 year ago

I'll take this issue first as ramp up. put and compile everything in a docker image could help understand the basic structure of the whole system.

jingedawang commented 1 year ago

Please join as a collaborator here: https://github.com/jingedawang/StockPredictor/invitations