search

jingweiz / pytorch-rl

Deep Reinforcement Learning with pytorch & visdom
MIT License
798 stars 143 forks source link

check mujoco dependency only when enable_continuous=True #4

Closed jingweiz closed 7 years ago

jingweiz commented 7 years ago

@onlytailei We should only require this dependency when enable_continuous=True. Can you check it first?

onlytailei commented 7 years ago

@jingweiz Yes. Will revise it soon.

jingweiz commented 7 years ago

@onlytailei Just change the default config to 5 and change a bit in README, should be fine now, can you pull the latest version and check it?

onlytailei commented 7 years ago

@jingweiz I find that this is no explicit dependency with mujoco (like import mujoco) in pytorch-rl. It is a implicit dependency in gym only if you try to start the related environments like "InvertedPendulum-v1" (https://gym.openai.com/envs#mujoco)

onlytailei commented 7 years ago

It is better that enable_continuous=True can be connected with the environment and set automatically.