jingwood / d2dlib

A .NET library for hardware-accelerated, high performance, immediate mode rendering via Direct2D.
MIT License
234 stars 40 forks source link

Any reason not to publish signed assemblies to NuGet? #84

Closed levicki closed 1 year ago

levicki commented 1 year ago

As the title says, what is the reason behind not signing the assemblies?

I am asking because of the following compiler warning:

CSC : warning CS8002: Referenced assembly 'd2dwinform, Version=1.3.1.0, Culture=neutral, PublicKeyToken=null' does not have a strong name.

I am aware that I can build the assemblies myself from the source code and sign them when I want them imported into another project that is itself using signing, but I don't see a good reason for the assembly not to be signed even if the key is made public in this repository.

If it is of any help, I reported the same issue with PCSC-Sharp assemblies and they fixed it in this pull request.

levicki commented 1 year ago

Thanks!