search

jingyu9575 / multithreaded-download-manager

Download manager extension for Firefox with multithreading support
Mozilla Public License 2.0
266 stars 36 forks source link

[Feature request] Allow setting more than 6 thread from within extension GUI instead of about:config #87

Closed Nokia808 closed 5 years ago

Nokia808 commented 5 years ago

Hi. On page of extension there is the following statement:

"If more than 6 threads are needed, open about:config, and increase the values of "network.http.max-persistent-connections-per-server" and "network.http.max-persistent-connections-per-proxy"."

Can you make this be possible from within GUI of your extension instead of "about:config" ? This will be more convenient.

jingyu9575 commented 5 years ago

Firefox does not allow that. Firefox 57+ extensions can only use a limited set of features, which does not include modifying about:config.

Nokia808 commented 5 years ago

@jingyu9575 Okay I understood. But what is the maximum value allowed ?

jingyu9575 commented 5 years ago

what is the maximum value allowed

255. Larger values have the same effects as 255.

Nokia808 commented 5 years ago

@jingyu9575 Thank you very much for support ! I learn new thing from you !

However, can you further assist me, though out of topic ?

1) Please see bellow screenshot:

parameters

As you see, by the chance, I discovered that there is a parameter is modified: extentions.dta.network.http.max-connections
It is modified inspite the fact that I did not touch it at all by my hand & no other person working on my PC ! I'm already installed many extension but all of them from Mozilla add-on page never from my official Fedora repositories so they should not be able to change about:config ! However, I was installing a download manager called XDM (extreme download manager) as an external package downloaded from their official site: http://xdman.sourceforge.net/ & this was need root to install it. Could XDM responsible for this change ? I already uninstalled it. Can you please inform me what is the default value for "extentions.dta.network.http.max-connections" ? & does setting of this parameter effect your extension adversely ?

2) By the way, after setting to 255 I noticed that there is no real increase in speed on links support multithread downloads. In fact browser built-in downloador was faster !! Moreover, download by your extension interrupted at middle & need to be re-run manually, which make extension loss from it's value too ! Is there need to open new bug about this ? I test on the following link: https://github-production-release-asset-2e65be.s3.amazonaws.com/56087776/a7637380-967a-11e9-87a9-f89b2d2cc1d9?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20190911%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20190911T053757Z&X-Amz-Expires=300&X-Amz-Signature=05c4b9d61d195e051d937211b6e0b04a7c20399b43ad3f8abf8c162deb190387&X-Amz-SignedHeaders=host&actor_id=0&response-content-disposition=attachment%3B%20filename%3DRambox-0.6.9-linux-x86_64.AppImage&response-content-type=application%2Foctet-stream

jingyu9575 commented 5 years ago

extentions.dta.network.http.max-connections

Probably from DownThemAll Legacy. It is a Firefox 56- extension that has more privileges. It has no effects if DownThemAll Legacy is not installed. You can remove it by right-clicking -> Reset.

no real increase in speed on links support multithread downloads

By default the extension creates 4 connections. You can increase it in the options.

However, whether multithreading can accelerate downloads depends on the network conditions. In some cases, multitheading will actually slow down the download. You need to choose single-threading or multithreading based on the conditions of your own network.

download by your extension interrupted at middle & need to be re-run manually

The links have expired now. If the link can expire in a short time, it probably cannot be downloaded with multitheading.

jingyu9575 commented 5 years ago

Multithreading is a long known technique for downloading, and different servers/networks react differently to it. Sometimes it simply cannot work, and it cannot be workarounded in the extension, as other multithreading extensions/programs will likely have the same issue.

Edit: DownThemAll Legacy has a feature that it will restart the download in single-threading mode, if it detects errors. This extension currently does not do that.

Nokia808 commented 5 years ago

@jingyu9575 1) I'm already increased thread from within GUI of extension to 255 also, so that it be compatible with 255 in about:config that I set ......

2) before restore default of " extentions.dta.network.http.max-connections" I forgot to mention that I already disabled WebRTC from within about:config for purpose of VPN by set: "media.peerconnection.enabled" to false Just issuer me that such disable of WebRTC is not related to the modification of "media.peerconnection.enabled"

jingyu9575 commented 5 years ago

I'm already increased thread from within GUI of extension to 255 also

Then it may be the network. Use whichever best method for you. I also often meet servers that are better accessed with a single thread.

media.peerconnection.enabled

media.peerconnection.enabled is WebRTC. If you set it to false WebRTC will be disabled. Unlike most config items, this can be set by extensions as a privacy feature.

This has no relations to extentions.dta.network.http.max-connections and reseting that one will not change this one.

Nokia808 commented 5 years ago

@jingyu9575 Thank you for assistant ! I will close this issue as long it is not allowed by Firefox quantum.