search

jingyu9575 / select-after-closing-current

Firefox extension to configure which tab to select after closing the current tab: left tab, right tab or last accessed tab.
https://addons.mozilla.org/firefox/addon/select-after-closing-current/
Mozilla Public License 2.0
34 stars 3 forks source link

Fails when using Ctrl+Click to open links from newtab #30

Open ghost opened 2 years ago

ghost commented 2 years ago

Some debugging has shown me that this is because openerTabIdis undefined when using ctrl+click. This causes the tab to never be inserted in the recent tabs object, so this addon fails to operate as expected (behaviour is exactly as described in #23)

Right-click and select 'open in new tab' works perfectly. I guess this is a firefox bug?

ghost commented 2 years ago

I've just noticed, I was testing this by opening links from about:newtab, and that's where it fails. Ctrl+click works as expected from other pages (and openerTabId is defined and valid). Middle click works either way.

I should mention that I'm on nightly FF.

ghost commented 1 year ago

I guess this is a firefox bug?

~~Seems so, I cannot reproduce this any more. Closing the issue for now, yay. Thanks for a super handy addon.~~

ghost commented 1 year ago

Apologies, this was appearing to be fixed due to my mouse bindings, it is in fact broken as described.