jingyu9575 / service-worker-control

Firefox extension to detect and control Service Workers on websites.
Mozilla Public License 2.0
10 stars 2 forks source link

Icon not adapting to Windows 10 dark mode? (Firefox 70) #7

Closed sprite-1 closed 4 years ago

sprite-1 commented 4 years ago

On Firefox 70, the icons for both Service Worker Control and Service Worker Control - Push Notification History don't seem to respect Windows 10's dark mode

image

jingyu9575 commented 4 years ago

The color is correct on my system:

图片

Try setting svg.context-properties.content.enabled to true in about:config.

sprite-1 commented 4 years ago

Setting svg.context-properties.content.enabled to true only fixed the Service Worker Control - Push Notification History icon, but the Service Worker Control is still black

jingyu9575 commented 4 years ago

I'm not sure what is happening. I tried on Firefox 70.0.1 with a new profile, and the icon in the address bar was already light when I first installed the extension.

图片

I'm using the built-in dark theme. Are you using this theme? Are there any other customizations on your browser?

sprite-1 commented 4 years ago

Oh crap I'm terribly sorry! I got the two mixed up! The Push Notification History is the one that isn't turning light. The main addon works as it should.

image

Sorry again for the confusion!

jingyu9575 commented 4 years ago

I just tested again. On my system, this icon is controlled by svg.context-properties.content.enabled:

MLkQ3yIKc1

I'm not sure what is happening here. Is it still black after restarting Firefox?

sprite-1 commented 4 years ago

Well... I just ended up going with the nuclear method and wiped my Firefox profile completely and it works properly now so I guess the issue can be closed now