Request: Change icon color at NavBar, identifying group

[EstherMoellman]

@jingyu9575 ,

My friend, please, if doable, I would like to request the following: A color to identify each group, in such way that TTBG' icon at NavBar/ToolBar/etc will show the color of the selected group.

Thank you!

PS: SimpleTabGroups add-on has this function, and is very useful, because users can quickly identify groups just by seeing the color of the icon.

[jingyu9575]

We need extension storage to save the groups color, otherwise they change on browser restart.

You see, with the restriction of not using extension storage, everything is difficult...

Workarounds:

1. Prepend symbols to title: ⚫🔵⚪🔴🟠🟣🟤🟡🟢
2. If we choose the Metadata approach in #14, save it there.

[EstherMoellman]

How exactly "1. Prepend symbols to title" will work? Where this colored circles will appear?

[jingyu9575]

Probably this:

It only needs to be stored in the bookmarks. In the extensions, we can change the icon, so we do not need to display the circles.

[jingyu9575]

Which do you think is better, circle or square? 🔵🔴🟠🟣🟤🟡🟢 🟦🟥🟧🟪🟫🟨🟩

[EstherMoellman]

Hi @jingyu9575 ! Circles seems to me a bit nicer, but both icons are fine. : )

[jingyu9575]

Try the latest build. Color can now be manually set by right-click, or by the option automatically set a color for every new group. However the toolbar icon does not show the color yet.

I think there is some color contrast issues, especially with the dark theme.

[EstherMoellman]

Very nice! Everything seems to works perfect. The right click also is very nice, allowing to change colors. Everything is almost perfect. Congrats and thank you.

I'm saying "almost", because we need the most important color identification: Toolbar icon. I understand you're experiencing troubles with contrast + dark theme. Two ideas:

1) Can you steal icon system color from SimpleTabGroups? At this add-on icon colors works perfect under dark theme.

2) If you can not use SimpleTabGroups' icon color system, and you also can not find another solution for coloring toolbar icon under dark theme and contrast... what about an icon badge with colors? If it is not possible icon badge with colors, in the worst case we can replace all the group color system with numbers, identifying groups not by colors, but by numbers... it has the same practical function! Both, colors or numbers, can identify groups. And if you use numbers (instead colors), you can use an icon badge with numbers... like PowerTabs does.

[jingyu9575]

I've manually tuned the colors, but I'm unable to get enough contrast for red, orange, yellow and brown. I think I'd remove brown and only keep 6 primitive colors here, unless someone can design the contrast better.

[EstherMoellman]

Perfect! : )

[EstherMoellman]

... just two more minor comments: 1) I believe you also can keep the original "white" (light theme) and "black" (dark theme) icon colors, for those users that don't want colors. 2) If by chance you can fill inside the icon with the group color, IMHO it will be nicer. I don't mean the icon background, just inside the icon.

[jingyu9575]

1. Right-click, set color, none. The extension won't generate any color if the option automatically set a color is not enabled.
2. Then it will look like the picture below. I'm not sure whether this is better...

[EstherMoellman]

1) Icon colors: ABSOLUTELY F-A-N-T-A-S-T-I-C! Perfect. Very nice. Hope they will have same nice look also at dark theme. But when I talked about "to fill", I meant the icon at toolbar, not at popup. Any chance to fill the icon at NabBar/Toolbar with the colors?

2) White/Black: I understand these two colors are going to work if users choose "set color none". But I still believe white/black (as primary colors) also may be useful if users want to identify groups by colors. However, the last word always is yours. Up to you. Personally, I think is already perfect what you did.

[jingyu9575]

Now the icon can be selected in the options. 3 is the filled icon.

white/black (as primary colors) also may be useful if users want to identify groups by colors

If the browser has the light theme, white won't be visible, and black will be the same as "none". The opposite happens if the dark theme is used. So I think white/black colors are difficult to use.

[EstherMoellman]

@jingyu9575 ... P-E-R-F-E-C-T AND O-U-T-S-T-A-N-D-I-N-G!... over-exceeded all expectations... beautiful and functional feature. I'm speechless. I just can say: Thank you and congrats.