search

jingyu987 / pe

0 stars 0 forks source link

Insufficient duplicate detection #6

Open jingyu987 opened 10 months ago

jingyu987 commented 10 months ago

Only exact matches for duplicate inputs are catered for allowing users to add items such as "Chicken Rice" and "Chicken Rice" with 1 additional space in between even though they are unlikely to be different items

image.png

Typically, it is best if you can give a warning in such near match cases so that the user can make the final decision.

nus-pe-bot commented 9 months ago

Team's Response

We will reject this as it is simply a typo on the user's part that causes the name of the item to become different than any that exists in the stall already, even if that difference is just 1 character.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: As seen in the screenshot below from the course website, duplicate detection doesnt consists of just exact string matching, it would be better if a warning could be given and leave the final choice up to the user. However this does occur in very rare situations and only causes minor inconvenience, therefore I believe it is a bug that is classified as severity.Low.

image.png