search

jingyuanli001 / RFR-Inpainting

The source code for CVPR 2020 accepted paper "Recurrent Feature Reasoning for Image Inpainting"
MIT License
355 stars 76 forks source link

Some questions regarding source code #31

Closed xiankgx closed 2 years ago

xiankgx commented 3 years ago

link

Two attributes 'stride' and 'prop_kernels' doesn't seem to be used. Can I remove them?

link 2

Line 150 seems to be redundant with the existence of line 151, please correct me if I'm wrong.

jingyuanli001 commented 3 years ago

Hi, thanks for printing this out. Yes, some of the parameters in the attention module is currently redundant, and you can safely remove them. This is the same for the second issue you pointed out.

xiankgx commented 3 years ago

Thank you author, I'm training a places2 model, hope it will work out well so I can wrap up my work.