search

jinh0 / eyeliner.nvim

👀 Move faster with unique f/F indicators.
461 stars 15 forks source link

🐛 fix: use default arg for highlights #6

Closed Univa closed 2 years ago

Univa commented 2 years ago

The default argument in the :hi calls were removed in the recent refactor commit (not sure if that was intentional): https://github.com/jinh0/eyeliner.nvim/commit/d1adaaeb292644dfb7958d3dbc8cace8315ea3e5

Removing this prevented EyelinerPrimary and EyelinerSecondary highlight group overrides from working properly in cases where the plugin is loaded after the override. An example of this is if you lazy-load the plugin after your colorscheme has been set up.

This might also relate to the recent discussion in issue #2, since adding default = true means that the user-defined highlight group override (outside of plugin's setup call) would be the source of truth if it exists.

jinh0 commented 2 years ago

Shoot, I didn't know about that! Thanks for the PR @Univa .