jinjie2088 / django-tagging

Automatically exported from code.google.com/p/django-tagging
Other
0 stars 0 forks source link

Add remove_tag() function for add_tag() parallelism #101

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
I've modified add_tag() to return a boolean indicating whether a tag was added 
and also added a 
parallel function for tag removal so that tags can be removed without modifying 
the other tags on 
the object.

Attached is a patch for those changes.

Original issue reported on code.google.com by john.m.h...@gmail.com on 27 Feb 2008 at 5:01

Attachments:

GoogleCodeExporter commented 9 years ago
Apologies, there was a typo in the original diff.  Corrected patch below.

Original comment by john.m.h...@gmail.com on 27 Feb 2008 at 5:54

Attachments:

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Thanks for the patch. Though it is rejected when I apply it (patch <
remove-tag.diff), it works fine when I copy-paste the code.

I wonder why there are no follow-ups to this issue. Is there another/a better 
way of
removing tags from objects? Or it has never occurred to anyone else to want to 
remove
a specific tag from an object?

A clarification from the maintainers would be very welcome.

Cheers

Original comment by mstamat on 16 Jun 2009 at 1:49

GoogleCodeExporter commented 9 years ago
The lack of remove_tag struck me as quite strange too. Not difficult to work 
around
but an obvious addition.

Original comment by andybak on 26 Feb 2010 at 4:03