search

jinjor / elm-xml-parser

XML parser for Elm
http://package.elm-lang.org/packages/jinjor/elm-xml-parser/latest
BSD 3-Clause "New" or "Revised" License
21 stars 10 forks source link

Fix parsing of escaped characters in attribute values #12

Open hgoes opened 4 years ago

hgoes commented 4 years ago

The textString function discarded all text prior to an escaped character. Example: XmlParser.parse """<t attr="ABC&#253;DEF"/>""" => Ok { docType = Nothing, processingInstructions = [], root = Element "t" [{ name = "attr", value = "ýDEF" }] [] }

With the fix:

Ok { docType = Nothing, processingInstructions = [], root = Element "t" [{ name = "attr", value = "ABCýDEF" }] [] }

miniBill commented 4 years ago

This fixes #13

dullbananas commented 4 years ago

@jinjor please merge this

miniBill commented 2 years ago

(premise: thank you for writing this library, I appreciate that being an open source maintainer is a lot of work and people can have different priorities in life)

Do you expect you'll be able to merge this or should we fork the library?